Support Publisher as a return type in RESTEasy Reactive as well #15532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Mar 8, 2021
| private void handleStreaming(ResteasyReactiveRequestContext requestContext, Multi<?> result, boolean json) { | ||
| result.subscribe().withSubscriber(new StreamingMultiSubscriber(requestContext, json)); | ||
| private void handleStreaming(ResteasyReactiveRequestContext requestContext, Publisher<?> result, boolean json) { | ||
| result.subscribe(new StreamingMultiSubscriber(requestContext, json)); |
There was a problem hiding this comment.
Not very important, but in the case of Multi (and only in this case - which would duplicate the code), you can do:
result.subscribe().withSafeSubscriber(...)
In this case, Mutiny disables all the serialization / TCK checks.
There was a problem hiding this comment.
That's nice!
We can use that actually by checking if result is Multi and doing this special handling in such a case.
There was a problem hiding this comment.
Weird, I can't find withSafeSubscriber anywhere :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15519