Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote dev mode fails on missing project directory #15500

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

mswiderski
Copy link
Contributor

this addresses the issue #15494 as the project directory is explicitly set to null here

@geoand you might be interested in this :)

with that remote dev mode starts and works!

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 5, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@mswiderski mswiderski changed the title remote dev mode fails on missing project directory Remote dev mode fails on missing project directory Mar 5, 2021
@quarkus-bot quarkus-bot bot added the area/core label Mar 5, 2021
@geoand
Copy link
Contributor

geoand commented Mar 5, 2021

Thanks for this!

@aloubyansky is the best person to review I would say

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the project dir being consumed from the CompilationProvider in Quarkus core. I am wondering whether we need it at all. Perhaps for Kogito? @mariofusco @evacchi

@evacchi
Copy link
Contributor

evacchi commented Mar 8, 2021

we do; are there "proper" ways to query for that value? /cc @danielezonca @mariofusco @tarilabs

@aloubyansky
Copy link
Member

I think it's ok. I just wanted to clarify that. Thanks @evacchi

@aloubyansky aloubyansky merged commit 89e244b into quarkusio:master Mar 8, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants