Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump neo4j-java-driver from 4.2.1 to 4.2.2 #15484

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2021

Bumps neo4j-java-driver from 4.2.1 to 4.2.2.

Commits
  • ac923b2 Update dependencies (#841)
  • 8d345b0 Update Netty to 4.1.59. (#836)
  • 4a7f272 Updating tests according to the server-side changes (#834) (#838)
  • 09db20b Removed the year component from all copyright notices. (#831)
  • 7b4e4f7 Corrected the logging behavior when a channel is marked inactive due to a gra...
  • 4c053ca Avoid 3rd party imports for Java Doc. (#823)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Mar 4, 2021
@gastaldi
Copy link
Contributor

gastaldi commented Mar 5, 2021

We're using Netty 4.1.49.Final and this version was built against 4.1.59.Final. Do you see any problem with this upgrade @michael-simons ?

@gastaldi
Copy link
Contributor

gastaldi commented Mar 5, 2021

Ah the test errors say it all:

Error: Could not find target method: static org.neo4j.driver.internal.shaded.io.netty.handler.ssl.SslContext org.neo4j.driver.internal.svm.Target_io_netty_handler_ssl_SslContext.newServerContextInternal(org.neo4j.driver.internal.shaded.io.netty.handler.ssl.SslProvider,java.security.Provider,java.security.cert.X509Certificate[],javax.net.ssl.TrustManagerFactory,java.security.cert.X509Certificate[],java.security.PrivateKey,java.lang.String,javax.net.ssl.KeyManagerFactory,java.lang.Iterable,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.CipherSuiteFilter,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.ApplicationProtocolConfig,long,long,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.ClientAuth,java.lang.String[],boolean,boolean,java.lang.String) throws javax.net.ssl.SSLException
com.oracle.svm.core.util.UserError$UserException: Could not find target method: static org.neo4j.driver.internal.shaded.io.netty.handler.ssl.SslContext org.neo4j.driver.internal.svm.Target_io_netty_handler_ssl_SslContext.newServerContextInternal(org.neo4j.driver.internal.shaded.io.netty.handler.ssl.SslProvider,java.security.Provider,java.security.cert.X509Certificate[],javax.net.ssl.TrustManagerFactory,java.security.cert.X509Certificate[],java.security.PrivateKey,java.lang.String,javax.net.ssl.KeyManagerFactory,java.lang.Iterable,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.CipherSuiteFilter,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.ApplicationProtocolConfig,long,long,org.neo4j.driver.internal.shaded.io.netty.handler.ssl.ClientAuth,java.lang.String[],boolean,boolean,java.lang.String) throws javax.net.ssl.SSLException
	at com.oracle.svm.core.util.UserError.abort(UserError.java:68)

@michael-simons
Copy link
Contributor

Duplicates #15456

@michael-simons
Copy link
Contributor

FYI neo4j/neo4j-java-driver#843 Sorry we shipped this, should not have happened, I messed up the CI.

@famod
Copy link
Member

famod commented Mar 5, 2021

@gsmet FYI, after my GIB workaround this now fails as expected.

@michael-simons so this update should be skipped in Quarkus, right?

@gsmet
Copy link
Member

gsmet commented Mar 5, 2021

Yes, we have to skip it. I already reverted it once, let's not do it twice :).

@gsmet gsmet closed this Mar 5, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 5, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 5, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.neo4j.driver-neo4j-java-driver-4.2.2 branch March 5, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants