Make sure compileClasspath is resolved before quarkusGenerateCode task #15454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
aloubyansky
reviewed
Mar 3, 2021
| */ | ||
| @CompileClasspath | ||
| public FileCollection getClasspath() { | ||
| return QuarkusGradleUtils.getSourceSet(getProject(), SourceSet.MAIN_SOURCE_SET_NAME).getCompileClasspath(); |
There was a problem hiding this comment.
Just curious, do you know what it was before this change?
There was a problem hiding this comment.
Actually, it was the same. This method declare a dependency on the compile classpath which will make sure that gradle resolve all dependency even included build (which was not always guaranteed). This has no effect on the compile classpath of the task.
aloubyansky
approved these changes
Mar 4, 2021
gsmet
approved these changes
Mar 4, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix add a "dependency" on dependency resolution. This make sure all dependencies are resolved before calling the code generation task.
This is needed because, when using included build, there was no guarantee that
quarkusGenerateCodewas run afterincluded-buildbuild. This was resulting in flaky test reporting a missing jar.cc @gsmet there should be less failures with this fix.