Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kotlin version to 1.4.31 #15421

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Bump kotlin version to 1.4.31 #15421

merged 1 commit into from
Mar 3, 2021

Conversation

evanchooly
Copy link
Member

fixes #11428

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Mar 2, 2021
@evanchooly evanchooly requested review from aloubyansky, geoand and gastaldi and removed request for aloubyansky March 2, 2021 21:53
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 2, 2021
aloubyansky
aloubyansky approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know it was duplicated. It should be set in one place. Can be done in a separate PR though.

@geoand
Copy link
Contributor

geoand commented Mar 3, 2021

Something is wrong with the Kubernetes tests... I need to check it out

@geoand
Copy link
Contributor

geoand commented Mar 3, 2021

#15426 fixes the CI issue

@geoand
Copy link
Contributor

geoand commented Mar 3, 2021

Can you rebase onto master please?

@gsmet gsmet merged commit 1516ef6 into quarkusio:master Mar 3, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 3, 2021
@evanchooly evanchooly deleted the kotlin1.4.31 branch March 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Setting the kotlin.version property to 1.4 doesn't update the Kotlin dependencies version
5 participants
@evanchooly @geoand @gastaldi @aloubyansky @gsmet