-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension registry client API #15413
Extension registry client API #15413
Conversation
...ols-common/src/main/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartCatalog.java
Show resolved
Hide resolved
Small comment on this: I think you will need to keep the fallback around. It's not obvious people will be able to access the registry in corporate environments (a lot of corporate environments have exceptions for Maven Central from what I saw these past months in user comments). |
1918828
to
6dd83a1
Compare
Just approved the change, not reviewed the full PR yet
Interestingly, one of the reasons to use the Maven backend/interface was to make it easily/easier available in corporate environments. If our tools will end being limited to the platform extensions in (many) corp.env. or be painful to configure we should re-consider the approach. One way to make it available OOTB would be to publish the non-platform extension catalogs to the Maven Central repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the changes on each of the 277 files impacted by this PR and they look decent. I request a couple of small changes though.
I have one suggestion: it would be nice to have a quarkus-devtools-registry-spi
module containing the SPI classes required to be implemented in the server side of a Registry (eg. the registry.quarkus.io app)
.../registry-client/src/main/java/io/quarkus/registry/catalog/json/JsonCatalogMapperHelper.java
Show resolved
Hide resolved
...istry-client/src/main/java/io/quarkus/registry/config/json/RegistriesConfigMapperHelper.java
Outdated
Show resolved
Hide resolved
...istry-client/src/main/java/io/quarkus/registry/config/json/RegistriesConfigMapperHelper.java
Outdated
Show resolved
Hide resolved
This PR doesn't really include anything that should be implemented on the server side. So, the module would be empty. |
6dd83a1
to
9b1c030
Compare
9b1c030
to
2a19009
Compare
Rebased since it introduced conflicts with 0d0bd91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…rm and/or non-platform extensions integrated into the command line devtools
2a19009
to
e33f4d7
Compare
This PR:
Until the default community registry service is available I implemented a fallback to resolving the platform descriptors directly from the BOM coordinates.
Fixes #12422