Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs typo #15397

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix docs typo #15397

merged 1 commit into from
Mar 2, 2021

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added the area/core label Mar 2, 2021
@geoand
Copy link
Contributor

geoand commented Mar 2, 2021

@famod @gsmet it seems that the incremental build failed here

@famod
Copy link
Member

famod commented Mar 2, 2021

Both test failures in the incremental build seem to be flakes:

  • Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.473 s <<< FAILURE! - in 
io.quarkus.it.container.image.GreetingResourceIT
Error:  io.quarkus.it.container.image.GreetingResourceIT.testHelloEndpoint  Time elapsed: 2.537 s  <<< ERROR!
javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake

  •   * What went wrong:
  Execution failed for task ':quarkusGenerateCode'.
  > Failed to process /tmp/multi-module-included-build7520368382476791116/external-library/build/libs/external-library-1.0.0-SNAPSHOT.jar

  * Exception is:
  org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':quarkusGenerateCode'.
  	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)
  	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)
  	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
  	<...>
  Caused by: org.gradle.api.GradleException: Failed to process /tmp/multi-module-included-build7520368382476791116/external-library/build/libs/external-library-1.0.0-SNAPSHOT.jar
  	at io.quarkus.gradle.builder.QuarkusModelBuilder.getDeploymentArtifact(QuarkusModelBuilder.java:295)
  	<...>
  Caused by: java.util.zip.ZipException: zip END header not found
  	at jdk.zipfs/jdk.nio.zipfs.ZipFileSystem.zerror(ZipFileSystem.java:1786)
  	at jdk.zipfs/jdk.nio.zipfs.ZipFileSystem.findEND(ZipFileSystem.java:1047)
  	at jdk.zipfs/jdk.nio.zipfs.ZipFileSystem.initCEN(ZipFileSystem.java:1056)
  	at jdk.zipfs/jdk.nio.zipfs.ZipFileSystem.<init>(ZipFileSystem.java:130)
  	at jdk.zipfs/jdk.nio.zipfs.ZipFileSystemProvider.newFileSystem(ZipFileSystemProvider.java:136)
  	at io.quarkus.gradle.builder.QuarkusModelBuilder.getDeploymentArtifact(QuarkusModelBuilder.java:287)
  	... 231 more

Especially that last one I have seen multiple times before.

@gsmet
Copy link
Member

gsmet commented Mar 2, 2021

Yes, we need to fix those :/ @glefloch have you seen the new Gradle failure? It looks related to the same issue as before and looks fairly consistent.

@geoand geoand merged commit 974e22f into quarkusio:master Mar 2, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 2, 2021
@glefloch
Copy link
Member

glefloch commented Mar 2, 2021

Yes I'm having a look. It seems task ordering is wrong. I will try something ;)

gsmet
gsmet reviewed Mar 2, 2021
View reviewed changes
core/deployment/src/main/java/io/quarkus/deployment/dev/DevConfig.java
@@ -10,7 +10,8 @@
/**
* Whether or not Quarkus should disable it's ability to not do a full restart
* when changes to classes are compatible with JVM instrumentation.
* If this is set to true, Quarkus will always restart on changes and never perform class redefinition.
*
* If this is set to false, Quarkus will always restart on changes and never perform class redefinition.
*/
@ConfigItem(defaultValue = "true")
boolean instrumentation;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a DevConfig while we already have a LiveReloadConfig?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LiveReload config is basically for remote-dev.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be renamed...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... we only had live reload config for remote dev until now. But I think quarkus.live-reload.instrumentation is a much better name than quarkus.dev.instrumentation and would be more consistent with the rest.

I can do the legwork if you all agree with it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, in hindsight it should have been under LiveReload, but because it was just for remote dev so far I did not think of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@stuartwdouglas @geoand @famod @gsmet @glefloch