-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid NPE in dev console when there aren't any indexed entities with the Hibernate Search extension enabled #15375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
approved these changes
Mar 1, 2021
Rebased to get the CI fix. |
gsmet
added
the
triage/waiting-for-ci
Ready to merge when CI successfully finishes
label
Mar 1, 2021
Signed-off-by: Yoann Rodière <[email protected]>
…rch devcard Signed-off-by: Yoann Rodière <[email protected]>
@gsmet The failure seems unrelated, I think we can merge this PR?
|
Yes, I was looking at the increment build results before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/hibernate-search
Hibernate Search
triage/waiting-for-ci
Ready to merge when CI successfully finishes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15352
Also includes a small cosmetic change in the Hibernate Search devcard to avoid confusing entity instances with entity types.