Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gradle annotationProcessorPath to compileClassPath #15365

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

glefloch
Copy link
Member

@glefloch glefloch commented Mar 1, 2021

This branch set the annotationProcessorPath of the gradle compile task to point to the compileClasspath.

By default annotation processors in the compileClasspath are not executed. It requires dependency to be declared with the annotationProcessor scope.

close #15104

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Mar 1, 2021
@glefloch glefloch requested review from gastaldi and aloubyansky March 1, 2021 08:21
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glefloch A comment about that would be useful to have in the code. So we don't forget why we did it and what will fail in case it gets removed.

@glefloch
Copy link
Member Author

glefloch commented Mar 1, 2021

@aloubyansky you are right, I added a comment :)

@gastaldi
Copy link
Contributor

gastaldi commented Mar 1, 2021

Question: wouldn't this override existing annotationProcessorPaths defined for the compile task?

@glefloch
Copy link
Member Author

glefloch commented Mar 1, 2021

I just tested it. If a user sets it in its build.gradle, it won't be overridden by the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llegalAccessError with Panache MongoDB and Gradle
4 participants