Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev UI - minor improvements #15332

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Dev UI - minor improvements #15332

merged 1 commit into from
Mar 3, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 25, 2021 •
edited
Loading

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/vertx labels Feb 25, 2021
@mkouba mkouba added area/dev-ui and removed area/arc Issue related to ARC (dependency injection) area/core area/vertx labels Feb 25, 2021
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/vertx labels Feb 25, 2021
@mkouba mkouba removed area/arc Issue related to ARC (dependency injection) area/core area/vertx labels Feb 25, 2021
@mkouba mkouba requested a review from gsmet March 1, 2021 09:39
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/vertx labels Mar 2, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Mar 2, 2021

Hm, the JDK11 builds fail with ReadTimeoutTestCase.testReadTimesOut:47 expected: <false> but was: <true> (Quarkus - RESTEasy - Deployment).

@gsmet
Copy link
Member

gsmet commented Mar 2, 2021

Yeah, that happens sometimes.

@mkouba
Dev UI - minor improvements
ca97d65 
- throw an exception instead of NOT_FOUND, resolves quarkusio#14872
- sort beans and observers, application components go first
- use FQCN where possible
@mkouba
Copy link
Contributor Author

mkouba commented Mar 3, 2021 

2021-03-03T11:39:38.6367085Z Caused by: io.fabric8.maven.docker.access.DockerAccessException: error pulling image configuration: Get https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/40/407cece1abfffb1e84b5feb8a763f3773c905c409e52c0ee5f57f33acf0c10c6/data?verify=1614774566-15Eh4L2WhCd6VqPd5GLXVQ2X434%3D: net/http: TLS handshake timeout

:-(

gsmet
gsmet approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look and it looks good.

@mkouba
Copy link
Contributor Author

mkouba commented Mar 3, 2021

@famod @gsmet FYI Quarkus CI incremental / Gradle Tests failed.

@gsmet
Copy link
Member

gsmet commented Mar 3, 2021

Thanks for pinging us. It's unrelated and @glefloch already fixed it hopefully.

@glefloch
Copy link
Member

glefloch commented Mar 3, 2021

@gsmet I spotted the issue yes, I’m working a fix :) it should not be hard to fix

@gsmet gsmet merged commit 4f8fcb4 into quarkusio:master Mar 3, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/core area/dev-ui area/vertx
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Dev UI - display better error messages instead of NOT_FOUND in Qute templates
3 participants
@mkouba @gsmet @glefloch