-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer output dir for hot deployment of resources #15312
Conversation
That solution has a side effect in config editor of dev mode console. Failed tests in |
I've turned to include the first |
cc8bd3e
to
42b633c
Compare
@stuartwdouglas probably something for you to look at. |
This won't help if the resource is modified though, as dev mode will copy the file without interpolation. On the face of it it appears ok but it is only a partial solution to the issue. |
It's true. Using a IDE the changes were copied with interpolation and dev mode doesn't detect any change. But using a usual text editor the dev mode detect changes and copy the source file without interpolation. To resolve the later situation will need to call Is ok merging that partial solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better than the current situation, so I am ok with merging.
@gsmet will it be necessary to rebase? Is it possible to be merged into 1.12 or only for the next minor? 😄 |
The original resources without Maven properties resolution were provided by Static Handler for `src/main/resources/META-INF/resources` files when running in dev mode. The strategy used for hot deployment doesn't consider the resources filtering. So the interpolation of Maven properties wasn't processed. Resolves quarkusio#15303
I think it's a bit too risky to be backported so it will be in 1.13. |
I totally agree. And I'm thinking about a set of changes over static resources. I've opened #15320 for provide customization of index page, but there are other improvements very useful. In a future moment I could invest a effort cataloging them. Thank you @gsmet and @stuartwdouglas! |
The original resources without Maven properties resolution were provided by Static Handler for
src/main/resources/META-INF/resources
files when running in dev mode. The strategy used for hot deployment doesn't consider the resources filtering. So the interpolation of Maven properties wasn't processed.Resolves #15303