Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentracing Kafka : upgrade lib and small doc enhancement #15304

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Opentracing Kafka : upgrade lib and small doc enhancement #15304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<opentracing-tracerresolver.version>0.1.8</opentracing-tracerresolver.version>
<opentracing-concurrent.version>0.2.0</opentracing-concurrent.version>
<opentracing-jdbc.version>0.0.12</opentracing-jdbc.version>
<opentracing-kafka.version>0.1.13</opentracing-kafka.version>
<opentracing-kafka.version>0.1.15</opentracing-kafka.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it to dependabot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, it contains a dependency to opentracing-api and we manage our own version (0.31 for the moment, latest is 0.33 I think), so we need to test it before upgrading it (I know that 0.1.15 works as I use it everyday).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes perfect sense to keep it out of it then!

<jaeger.version>0.34.3</jaeger.version>
<quarkus-http.version>3.1.0.Beta2</quarkus-http.version>
<jboss-servlet-api_4.0_spec.version>1.0.0.Final</jboss-servlet-api_4.0_spec.version>
Expand Down
1 change: 0 additions & 1 deletion docs/src/main/asciidoc/opentracing.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ The https://github.com/opentracing-contrib/java-kafka-client[Kafka instrumentati
<dependency>
<groupId>io.opentracing.contrib</groupId>
<artifactId>opentracing-kafka-client</artifactId>
<version>${opentracing-kafka.version}</version>
</dependency>
----

Expand Down