Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArC - remove build items deprecated in 1.11 #15276

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 23, 2021

No description provided.

@mkouba mkouba requested a review from manovotn February 23, 2021 16:08
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/documentation area/narayana Transactions / Narayana area/rest-client area/security labels Feb 23, 2021
@mkouba mkouba added this to the 1.13 - master milestone Feb 23, 2021
@gsmet
Copy link
Member

gsmet commented Feb 23, 2021

@mkouba cool, nice to have this one early in the cycle as it might require some fixes in other projects!

// log a warning and recommend to use StartupEvent instead
final String observerWarning = "The method %s#%s is an observer for " +
"@Initialized(ApplicationScoped.class). Observer notification for this event may " +
"vary between JVM and native modes! We strongly recommend to observe StartupEvent " +
Copy link
Contributor

@gastaldi gastaldi Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"vary between JVM and native modes! We strongly recommend to observe StartupEvent " +
"vary between JVM and native modes! We strongly recommend to create a method that observes StartupEvent " +

Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsmet gsmet merged commit a9b7a96 into quarkusio:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/documentation area/narayana Transactions / Narayana area/rest-client area/security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants