-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native-source package type #15233
Conversation
@jerboaa @ebaron here is the initial work for #15208. What it does create the same directory that the $GRAALVM_HOME/bin/native-image $(cat native-image.args) The output directory for the is package type is stable, it's named Please try it out with the workflow you have in mind and let me know. |
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java
Outdated
Show resolved
Hide resolved
I can wait for those to be merged if needed |
#14635 was merged so I now need to rebase this onto the latest version of the code |
PR has been rebased onto master and taken out of draft. Please take a look :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @geoand
Thanks for the review @zakkak |
This package type is meant to support workflows where the actual native-image is created by a different container than the one that run that Quarkus build. Resolves: quarkusio#15208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Loved it!
@geoand I missed this yesterday, but won't the native sources build not include the results of native image only build steps? If something is using |
That's a good question, should they actually be included? We would probably have to look at each one |
I'll go through them one by one and change the ones that need to be changed. |
…tive Furthermore, fail the build when native-sources is requested but the extension creates its own output Related to: quarkusio#15233 (comment)
Draft PR is here: #15291 I want it to run on my fork before I request a review |
…tive Furthermore, fail the build when native-sources is requested but the extension creates its own output Related to: quarkusio#15233 (comment)
…ative Furthermore, fail the build when native-sources is requested but the extension creates its own output Related to: quarkusio/quarkus#15233 (comment)
This package type is meant to support workflows where the actual native-image is created by a different
container than the one that run that Quarkus build.
Resolves: #15208