Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPC client onClose and onMessage should be hanled on same thread #15212

Merged
merged 1 commit into from
Feb 21, 2021
Merged

GRPC client onClose and onMessage should be hanled on same thread #15212

merged 1 commit into from
Feb 21, 2021

Conversation

Andro999b
Copy link
Contributor

@Andro999b Andro999b commented Feb 20, 2021 •
edited by gsmet
Loading

Fixes #15187

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Feb 20, 2021
@Andro999b
Copy link
Contributor Author

@cescoffier

gsmet
gsmet requested changes Feb 20, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the 2 commits? Thanks!

@Andro999b
Copy link
Contributor Author

@gsmet done

@gsmet gsmet merged commit aa802d8 into quarkusio:master Feb 21, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 21, 2021
@gsmet
Copy link
Member

gsmet commented Feb 21, 2021

Thanks!

@gsmet
Copy link
Member

gsmet commented Feb 21, 2021

I will backport it to 1.12.1.Final.

@gsmet gsmet modified the milestones: 1.13 - master, 1.12.1.Final Feb 24, 2021
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/grpc gRPC
Projects
None yet
Milestone
1.12.1.Final
Development

Successfully merging this pull request may close these issues.

GRPC client stream onMessage and onClose executes on different threads
3 participants
@Andro999b @gsmet @cescoffier