Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - fix validation of primitives #15161

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Qute - fix validation of primitives #15161

merged 1 commit into from
Feb 18, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 18, 2021

  • fix a regression caused by
    2b01ca7

@mkouba mkouba requested a review from gsmet February 18, 2021 09:44
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Feb 18, 2021
@mkouba mkouba added triage/backport? and removed area/qute The template engine labels Feb 18, 2021
gsmet
gsmet approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it fixes the issue of the Status app.

@gsmet
Copy link
Member

gsmet commented Feb 18, 2021

I created #15163 to fix the build issue. I will rebase once this is merged.

@gsmet gsmet force-pushed the qute-primitive-validation-fix branch from de57c4d to c4835c2 Compare February 18, 2021 11:07
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Feb 18, 2021
@gsmet gsmet merged commit 307fde3 into quarkusio:master Feb 18, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 18, 2021
@gsmet
Copy link
Member

gsmet commented Feb 18, 2021

Thanks for the quick fix!

@gsmet gsmet modified the milestones: 1.13 - master, 1.12.1.Final Feb 19, 2021
@mkouba mkouba mentioned this pull request Feb 25, 2021
Closed
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/qute The template engine
Projects
None yet
Milestone
1.12.1.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@mkouba @gsmet