Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure versions are mocked in snapshots tests #15146

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Feb 17, 2021

Fixes #15142

@quarkus-bot quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Feb 17, 2021
@ia3andy ia3andy requested a review from gsmet February 17, 2021 13:17
@ia3andy ia3andy changed the title Make sure version is mocked in snapshots Make sure version is mocked in snapshots tests Feb 17, 2021
@ia3andy ia3andy changed the title Make sure version is mocked in snapshots tests Make sure versions are mocked in snapshots tests Feb 17, 2021
@ia3andy ia3andy force-pushed the fix-version-snapshots branch from e4f4b90 to f5758fc Compare February 17, 2021 13:20
@gsmet
Copy link
Member

gsmet commented Feb 17, 2021

@glefloch a test is often failing for Gradle Windows: https://scans.gradle.com/s/uevlpnn7ufycc/tests/:test/io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest/main()#1

I wonder if it could be related to the fast-jar change given we don't really expect a build/libs/ directory now but I'm not really sure given I only have seen it fail on Windows and not consistently.

@glefloch
Copy link
Member

Yes I'm having a look, this is weird. The failing module is a dependency and gradle outputs jar to build/libs by default, so this shouldn't be related to the fat jar change.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will try that for the next release.

@gsmet gsmet merged commit 35ef135 into quarkusio:master Feb 18, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 18, 2021
@ia3andy
Copy link
Contributor Author

ia3andy commented Feb 18, 2021

@gsmet cool, sorry about this.

We need to be careful when switching code gen tests to snapshot testing, while it's easy to convert and gives a check of the whole file, most of them are not designed with mocks.

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some code start tests test the version which is not compatible with releases
3 participants