-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure versions are mocked in snapshots tests #15146
Conversation
e4f4b90
to
f5758fc
Compare
@glefloch a test is often failing for Gradle Windows: https://scans.gradle.com/s/uevlpnn7ufycc/tests/:test/io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest/main()#1 I wonder if it could be related to the fast-jar change given we don't really expect a |
Yes I'm having a look, this is weird. The failing module is a dependency and gradle outputs jar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will try that for the next release.
@gsmet cool, sorry about this. We need to be careful when switching code gen tests to snapshot testing, while it's easy to convert and gives a check of the whole file, most of them are not designed with mocks. |
Fixes #15142