Enable Java serialization only for GraalVM 21+ #15145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsmet I tested GraalVM 21.0.0 with quarkus from your branch and serialization works. |
|
@Sgitario I let you confirm to me this fixes the issue you have. Thanks! |
I've verified this change and It's working fine. Thanks for fixing! |
|
OK, thanks to both of you, I will merge then! |
|
@gsmet seems that your change is now revealing an issue in version parsing for Mandrel |
|
A fix is underway for this on the mandrel side. Sorry about that. No action needed from Quarkus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #15085 .
@JiriOndrusek could you check serialization still works for you with GraalVM 21?
@Sgitario could you check things work fine with GraalVM 20.3? (I tested our Kafka IT but I'm not sure it's enough)