Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper metrics path in Kubernetes annotation #15119

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 16, 2021

Fixes: #15118

@@ -73,7 +73,7 @@ public void assertGeneratedResources() throws IOException {
assertThat(deploymentSpec.getTemplate()).satisfies(t -> {
assertThat(t.getMetadata()).satisfies(meta -> {
assertThat(meta.getAnnotations()).contains(entry("prometheus.io/scrape", "true"),
entry("prometheus.io/path", "/met"), entry("prometheus.io/port", "9090"),
entry("prometheus.io/path", "/q/metrics"), entry("prometheus.io/port", "9090"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changed from met to the default of metrics here because I removed quarkus.smallrye-metrics.path for this test as I also wanted to have a test that used the default path

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 16, 2021
@gsmet
Copy link
Member

gsmet commented Feb 16, 2021

This failure looks very weird:

Error:  Failures: 
Error:    SseTestCase.testSseFromMulti:46->testSse:71 expected: java.util.Arrays$ArrayList@71ef0890<[hello, stef]> but was: java.util.ArrayList@27a9d59<[hello, stef]>

The content looks identical and the equals from List are supposed to compare the elements so I wonder what's wrong.

@geoand
Copy link
Contributor Author

geoand commented Feb 16, 2021

This failure looks very weird:

Error:  Failures: 
Error:    SseTestCase.testSseFromMulti:46->testSse:71 expected: java.util.Arrays$ArrayList@71ef0890<[hello, stef]> but was: java.util.ArrayList@27a9d59<[hello, stef]>

The content looks identical and the equals from List are supposed to compare the elements so I wonder what's wrong.

I'll take a quick look at it tomorrow

geoand added a commit to geoand/quarkus that referenced this pull request Feb 16, 2021
@geoand
Copy link
Contributor Author

geoand commented Feb 16, 2021

This failure looks very weird:

Error:  Failures: 
Error:    SseTestCase.testSseFromMulti:46->testSse:71 expected: java.util.Arrays$ArrayList@71ef0890<[hello, stef]> but was: java.util.ArrayList@27a9d59<[hello, stef]>

The content looks identical and the equals from List are supposed to compare the elements so I wonder what's wrong.

I opened #15119 which should fix the issue, but even if it doesn't, it at least will provide better error messages

@geoand geoand merged commit 0ceea80 into quarkusio:master Feb 16, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 16, 2021
@geoand geoand deleted the #15118 branch February 16, 2021 19:51
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
@famod famod removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 17, 2021
@gsmet gsmet modified the milestones: 1.12.0.Final, 1.11.4.Final Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/metrics uri in generated kubernetes.yml is wrong
4 participants