-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper metrics path in Kubernetes annotation #15119
Conversation
@@ -73,7 +73,7 @@ public void assertGeneratedResources() throws IOException { | |||
assertThat(deploymentSpec.getTemplate()).satisfies(t -> { | |||
assertThat(t.getMetadata()).satisfies(meta -> { | |||
assertThat(meta.getAnnotations()).contains(entry("prometheus.io/scrape", "true"), | |||
entry("prometheus.io/path", "/met"), entry("prometheus.io/port", "9090"), | |||
entry("prometheus.io/path", "/q/metrics"), entry("prometheus.io/port", "9090"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It changed from met
to the default of metrics
here because I removed quarkus.smallrye-metrics.path
for this test as I also wanted to have a test that used the default path
This failure looks very weird:
The content looks identical and the |
I'll take a quick look at it tomorrow |
I opened #15119 which should fix the issue, but even if it doesn't, it at least will provide better error messages |
Fixes: #15118