-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have Hibernate Reactive depend on quarkus-mutiny correctly #15112
Conversation
<!-- Make sure Quarkus can manage Mutiny via quarkus-mutiny --> | ||
<exclusion> | ||
<groupId>io.smallrye.reactive</groupId> | ||
<artifactId>mutiny</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? I'd expect the dependency management in the BOM to be enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the exclusion is not needed but doesn't hurt either.
Yes, the BOM should be enough, but users don't always use our BOM.
Shouldn't matter also as we're hoping to keep the versions aligned but this
should be safer.
…On Tue, 16 Feb 2021, 16:09 Yoann Rodière, ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In extensions/hibernate-reactive/runtime/pom.xml
<#15112 (comment)>:
> @@ -34,6 +34,17 @@
<dependency>
<groupId>org.hibernate.reactive</groupId>
<artifactId>hibernate-reactive-core</artifactId>
+ <exclusions>
+ <!-- Make sure Quarkus can manage Mutiny via quarkus-mutiny -->
+ <exclusion>
+ <groupId>io.smallrye.reactive</groupId>
+ <artifactId>mutiny</artifactId>
Is this really necessary? I'd expect the dependency management in the BOM
to be enough.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15112 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKMTKYUIQPPEZNWLRDMVDS7KKFLANCNFSM4XWUV5GQ>
.
|
@gsmet I can't merge it because Yoann's review isn't authoritative enough.. let's fix that at the next round? |
Milestone is already set for some of the items:
We haven't automatically updated the milestones for these items.
|
I will do 2 more rounds of backports so it will be included. |
Fixes #15111