Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Hibernate Reactive depend on quarkus-mutiny correctly #15112

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Feb 16, 2021

Fixes #15111

@quarkus-bot quarkus-bot bot added area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE labels Feb 16, 2021
<!-- Make sure Quarkus can manage Mutiny via quarkus-mutiny -->
<exclusion>
<groupId>io.smallrye.reactive</groupId>
<artifactId>mutiny</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary? I'd expect the dependency management in the BOM to be enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the exclusion is not needed but doesn't hurt either.

@Sanne
Copy link
Member Author

Sanne commented Feb 16, 2021 via email

@Sanne Sanne added this to the 1.12.0.Final milestone Feb 16, 2021
@Sanne
Copy link
Member Author

Sanne commented Feb 16, 2021

@gsmet I can't merge it because Yoann's review isn't authoritative enough.. let's fix that at the next round?

@gsmet gsmet merged commit 4cf7bfc into quarkusio:master Feb 16, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 16, 2021

Milestone is already set for some of the items:

  • The pull request itself

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@gsmet
Copy link
Member

gsmet commented Feb 16, 2021

I will do 2 more rounds of backports so it will be included.

@Sanne Sanne deleted the hibernate-reactive-mutiny branch February 16, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate Reactive component is missing the dependency to Quarkus-Mutiny
3 participants