Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mutiny and Vert.x Core extensions to Vault dependencies #15107

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Add Mutiny and Vert.x Core extensions to Vault dependencies #15107

merged 3 commits into from
Feb 16, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 16, 2021

Fixes #15103

@quarkus-bot quarkus-bot bot added the area/spring Issues relating to the Spring integration label Feb 16, 2021
@gsmet
Copy link
Member Author

gsmet commented Feb 16, 2021

Also fixed it for the Spring Cloud Config extension which had the same sort of changes.

@geoand
Copy link
Contributor

geoand commented Feb 16, 2021

Since you did this anyway, can you also update Consul?

@gsmet
Copy link
Member Author

gsmet commented Feb 16, 2021

Done. I have an email in the works for extension maintainers to check their extensions.

@geoand
Copy link
Contributor

geoand commented Feb 16, 2021

Cool, thanks

@vsevel
Copy link
Contributor

vsevel commented Feb 16, 2021

thanks @gsmet

@gsmet
Copy link
Member Author

gsmet commented Feb 16, 2021

Could I get an approval? :)

@gsmet gsmet merged commit 2c18492 into quarkusio:master Feb 16, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 16, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/spring Issues relating to the Spring integration area/vault
Projects
None yet
Milestone
1.12.0.Final
Development

Successfully merging this pull request may close these issues.

Vault requires extension quarkus-vertx-core in 1.12.0.CR1
3 participants
@gsmet @geoand @vsevel