Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on quarkus-test-common in independent-projects/arc/tests #15079

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Feb 15, 2021

@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Feb 15, 2021
@manovotn
Copy link
Contributor

@gastaldi I think there is little point in re-declaring the mock annotation in Arc tests - the purpose of the test was to cover the @io.quarkus.test.Mock feature.
Therefore, to be free of the dependency and keep the tests sensible, we'd need to take these tests and move them into another module.

@gastaldi
Copy link
Contributor Author

@gastaldi I think there is little point in re-declaring the mock annotation in Arc tests - the purpose of the test was to cover the @io.quarkus.test.Mock feature.

Are you sure? The tests seem to reuse the @Mock annotation as a separate qualifier only, not the @Mock feature

@manovotn
Copy link
Contributor

Hmm, the test was added as part of #2780 which relates to the mock functionality.
It tests that you can manually override @Priority on it. Although you're right that this can be tested on any such annotation.
Plus I found one another test (in kafka extension) that actually uses @Mock so we don't completely stop testing it.

@manovotn manovotn merged commit c5b2520 into quarkusio:master Feb 16, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 16, 2021
@gastaldi gastaldi deleted the mock branch February 16, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants