-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate annotation processors again for panache #15064
Conversation
@stuartwdouglas |
FTR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want PanacheAnnotationProcessor (a28d76b#diff-3b62cdfb1058fa132560380d194f6b00371f9426fdc7f4bf759a2ccb36c7febaR28) to be run, can you change this to just run the hibernate one?
@stuartwdouglas done |
Can we also add a test for this to make sure that we don't run into this in future? Otherwise looks good. |
@stuartwdouglas Added a simple test to hibernate-panache and hibernate-reactive-panache, which just checks if the metamodel was generated. |
We depend on the jpamodelgen annotation processor in the panache modules, to create the Meta Model for e.g. the PanacheEntity class.
Thanks @Postremus! |
@ninaHerpertz Simply adding the hibernate-jpamodelgen annotation processor should work in your case. See https://quarkus.io/guides/hibernate-orm-panache#defining-entities-in-external-projects-or-jars You need to do this anyway, even for PanacheEntity. |
We depend on the jpamodelgen annotation processor in the panache modules, to create the Meta Model for e.g. the PanacheEntity class.
closes #14926