Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg and docs for aws lambda and HTTP (API Gateway HTTP vs. REST API) #15052

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

patriot1burke
Copy link
Contributor

There are no code changes. Only directory and artifact renames:

  • quarkus-amazon-lambda-http-v1 was renamed to quarkus-amazon-lambda-rest
  • All directory and module names were renamed to reflect this change
  • The AWS Lambda + HTTP guide was changed to reflect this organization

AWS has two separate API Gateway APIs. HTTP and REST. This is implemented in two separate quarkus extensions. As stated on the dev list, it just doesn't make sense to put everything into one quarkus extension. There are different deployment scripts (sam.yaml), a different lambda json protocol, and there is not any shared runtime code. While the same microservice could be deployed to either Gateway API, the developer will have to redeploy their service anyways. Its not like they can change an environment variable and respin an instance. So again, I kept them as separate extensions.

@gastaldi
Copy link
Contributor

CI Failed with

org.apache.maven.shared.dependency.graph.DependencyGraphBuilderException: Could not resolve following dependencies: [io.quarkus:quarkus-amazon-lambda-http-v1:pom:999-SNAPSHOT (test)]: Could not resolve dependencies for project io.quarkus:quarkus-bom-quarkus-platform-descriptor:pom:999-SNAPSHOT: Could not find artifact io.quarkus:quarkus-amazon-lambda-http-v1:pom:999-SNAPSHOT 

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Feb 17, 2021
@gsmet gsmet merged commit 4868b64 into quarkusio:master Feb 19, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 19, 2021
@patriot1burke patriot1burke deleted the aws-lambda-rest-api branch February 19, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/amazon-lambda area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants