Dev UI - add basic monitoring of CDI components

[mkouba]

• by default, fired events and business method invocations are monitored
• quarkus.arc.dev-mode-monitoring=false disables the feature

[gsmet]

Added a small comment/question.

Brain freeze.

[manovotn]

I played with this on some quickstarts and I think it is a great tool! Also, using CDI to monitor CDI is brilliant ;-)
Left just two minor comments, otherwise I am simply +1 for this.

[gsmet]

I played a bit with it with my Quarkus Bot Java app.

A couple of things:

• fired events are numbered from 1. but they are sorted in anti-chronological order. So every time you fire a new event, the events are renumbered, which is weird.
• for invocation trees, I think you should had % based width for the table. Otherwise, every time I click on the + icon in the tree, the width changes, which is a bit annoying.
• still invocation trees, I find it weird you don't sum up the invocation times of the tree somehow. Maybe you should have two values. See screenshot.
  

[mkouba]

fired events are numbered from 1. but they are sorted in anti-chronological order. So every time you fire a new event, the events are renumbered, which is weird.

Yes, the latest events/invocations are listed first and the number is just an index, a position in the table. We could just skip this column but I always find it useful when displaying a table...

for invocation trees, I think you should had % based width for the table. Otherwise, every time I click on the + icon in the tree, the width changes, which is a bit annoying.

Ok, I can try do something with this but I'm no CSS master ;-). (it looks ok in FF BTW)

still invocation trees, I find it weird you don't sum up the invocation times of the tree somehow. Maybe you should have two values.

Hm, that could be a bug with CP or something like that. The duration of the root must always be greater than the sum of the children.

[gsmet]

Yes, the latest events/invocations are listed first and the number is just an index, a position in the table. We could just skip this column but I always find it useful when displaying a table...

It's useful if it's stable. If it changes every time we get an event, I think it's not such a good idea. Can't you have 1. for the oldest event instead? This way, you would have a number and something that's stable.

If not, I would drop it.

Ok, I can try do something with this but I'm no CSS master ;-). (it looks ok in FF BTW)

I think just adding style="width:xx%" to the ths should be enough. If not I can have a look.

Hm, that could be a bug with CP or something like that. The duration of the root must always be greater than the sum of the children.

Well, you have seen my screenshot :). Who could help on this?

[mkouba]

@gsmet all your commets should be addressed now ;-)

[manovotn]

I am just putting my green stamp here as all my previous comments were addressed.
But we should still wait until Guillaume gives his approval.

[gsmet]

Woot, thanks! That's very useful!