Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate Reactive 1.0.0.Beta4 #14978

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Feb 10, 2021

No description provided.

@Sanne Sanne added the area/hibernate-reactive Hibernate Reactive label Feb 10, 2021
@ghost ghost added the area/dependencies Pull requests that update a dependency file label Feb 10, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 10, 2021
@gsmet
Copy link
Member

gsmet commented Feb 10, 2021

@mkouba @radcortez the Windows build failed with this error:

Caused by: java.util.NoSuchElementException: SRCFG00027: Could not find a mapping for io.quarkus.arc.test.config.ConfigMappingTest$Collections
	at io.smallrye.config.ConfigMappings.getConfigMapping(ConfigMappings.java:57)
	at io.smallrye.config.ConfigMappings.getConfigMapping(ConfigMappings.java:47)
	at io.smallrye.config.SmallRyeConfig.getConfigMapping(SmallRyeConfig.java:232)
	at io.quarkus.arc.runtime.ConfigMappingCreator.create(ConfigMappingCreator.java:17)
	at io.quarkus.arc.test.config.ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.create(ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.zig:121)
	at io.quarkus.arc.test.config.ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.get(ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.zig:152)
	at io.quarkus.arc.test.config.ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.get(ConfigMappingTest_Collections_2bd928ae5c9c1fbdf3ffd5f20e38ca31d78769fe_Synthetic_Bean.zig:175)
	at io.quarkus.arc.impl.CurrentInjectionPointProvider.get(CurrentInjectionPointProvider.java:52)
	at io.quarkus.arc.test.config.ConfigMappingTest_Bean.create(ConfigMappingTest_Bean.zig:654)
	... 51 more

could you have a look?

@radcortez
Copy link
Member

Sure, I'll have a look.

@radcortez
Copy link
Member

@gsmet I've tried to reproduce the error in a VM with Windows with no luck.

Also, I don't see how the hibernate update may break this test. It happens way before the hibernate dependencies kick in the reactor.

Regarding the test, it is testing a mapping class that it is pre generated in the arc config step and register in runtime init in the Config. It just seems that the class was not registered at all and it failed the test. Usually when registration fails, an exception is thrown, but I don't see any exception either.

Let me restart the CI and see what happens.

@geoand geoand merged commit 12cabc0 into quarkusio:master Feb 11, 2021
@ghost ghost added this to the 1.13 - master milestone Feb 11, 2021
@Sanne Sanne deleted the UpgradeHR branch February 11, 2021 09:20
@Sanne
Copy link
Member Author

Sanne commented Feb 11, 2021

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-reactive Hibernate Reactive triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants