-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jpa-security custom password type #14785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but I wonder if we shouldn't store the instance of PasswordProvider
in the generated class, instead of re-creating it every time we need it?
WDYT?
Absolutely agree |
@FroMage PR updated! |
...deployment/src/main/java/io/quarkus/security/jpa/deployment/QuarkusSecurityJpaProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny remark left. But this looks good. Can you squash your commits, though?
...deployment/src/main/java/io/quarkus/security/jpa/deployment/QuarkusSecurityJpaProcessor.java
Outdated
Show resolved
Hide resolved
Done. Running checks... |
OK merged, thanks a lot! |
Fix #14284
Changes
CUSTOM
attribute to the enumPasswordType
.provider
attribute to the annotationPassword
CUSTOM
inQuarkusSecurityJpaProcessor.java
Usage
/cc @FroMage @gsmet