Set keycloak-authorization proxy url #14778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Feb 2, 2021
| @@ -114,6 +114,10 @@ public void init(OidcConfig oidcConfig, KeycloakPolicyEnforcerConfig config, Tls | |||
| adapterConfig.setAllowAnyHostname(true); | |||
| } | |||
|
|
|||
| if (oidcConfig.defaultTenant.proxy.host.isPresent()) { | |||
| adapterConfig.setProxyUrl(oidcConfig.defaultTenant.proxy.host.get() + ":" + oidcConfig.defaultTenant.proxy.port); | |||
There was a problem hiding this comment.
No checks against proxy.port?
There was a problem hiding this comment.
@gastaldi It is defaulted to 80
pedroigor
requested changes
Feb 2, 2021
There was a problem hiding this comment.
@sberyozkin LGTM, except for @gastaldi comment.
Did you define a default port for quarkus-oidc?
|
@pedroigor Yeah :-) OidcCommonConfig.proxy |
|
MP tests have failed, not related |
pedroigor
approved these changes
Feb 3, 2021
|
Thanks, since it was only MP related build which failed I'll merge, CI seems unstable right now otherwise... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14733
This PR sets it as for example
localhost:80.Keycloak adapter code checks it like this:
where the scheme is defaulted to
httpwhich users can override by setting the host tohttps://localhostetc