Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect JUnit dependency #14723

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix incorrect JUnit dependency #14723

merged 1 commit into from
Feb 1, 2021

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@ghost ghost added the area/maven label Feb 1, 2021
geoand
geoand approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@geoand geoand merged commit 8f6aece into quarkusio:master Feb 1, 2021
@ghost ghost added this to the 1.12 - master milestone Feb 1, 2021
@famod
Copy link
Member

famod commented Feb 1, 2021

This could be prevented via bannedDependencies enforcer rule. I think a separate execution is required because some modules bring in Junit4 transitively (quarkus-test-arquillian & quarkus-test-kubernetes-client).

@gsmet
Copy link
Member

gsmet commented Feb 1, 2021

I think we should move those two to use Junit 5 too.

@geoand
Copy link
Contributor

geoand commented Feb 1, 2021

Yeah, I don't see why they are on JUnit 4

@famod
Copy link
Member

famod commented Feb 1, 2021

Well, AFAIK Arquillian Junit5 support is still in alpha stage.
The Kubernetes test client is using mockwebserver and from what I can tell, that project is still in the process of migrating to Junit5.

@stuartwdouglas
Copy link
Member Author

Arquillian needs JUnit 4 support because that is what the TCK's are written with, even if there was a JUnit 5 Arquillian we can't move until the TCK move.

@gsmet gsmet modified the milestones: 1.12 - master, 1.11.2.Final Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/maven
Projects
None yet
Milestone
1.11.2.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartwdouglas @famod @gsmet @geoand