Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AppCDS generation in Jib built container images #14655

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Add support for AppCDS generation in Jib built container images #14655

merged 2 commits into from
Feb 3, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 27, 2021

Fixes: #14607

@ghost ghost added the area/core label Jan 27, 2021
@geoand geoand requested a review from stuartwdouglas January 27, 2021 17:33
@geoand geoand added this to the 1.12 - master milestone Jan 27, 2021
@geoand geoand force-pushed the #14607 branch 2 times, most recently from aa9aa9a to d7854b2 Compare January 27, 2021 17:43
@geoand geoand mentioned this pull request Jan 27, 2021
Closed
@geoand geoand changed the title Add support for AppCDS generation in Jib built container-image Add support for AppCDS generation in Jib built container images Jan 27, 2021
@geoand
Copy link
Contributor Author

geoand commented Jan 27, 2021

CI is failing on the new test I added - which is weird because it passed locally.
I'll look into it

@geoand geoand force-pushed the #14607 branch 5 times, most recently from 4952c33 to bbf88af Compare January 28, 2021 09:29
@geoand geoand marked this pull request as draft January 28, 2021 13:07
@geoand
Allow AppCDS generation from using a builder image
4312bfe 
The is useful when the building JVM version is not the same
as the runtime JVM version
@geoand geoand force-pushed the #14607 branch 2 times, most recently from b7fe78c to 1e523d4 Compare January 28, 2021 15:42
@geoand geoand marked this pull request as ready for review January 28, 2021 15:42
@geoand
Copy link
Contributor Author

geoand commented Jan 28, 2021

@stuartwdouglas PR should be ready now

@geoand
Copy link
Contributor Author

geoand commented Jan 29, 2021

This will also require some documentation - probably a blog post on quarkus.io

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2021

@stuartwdouglas can you take a look and let me know what you think?

Thanks

@stuartwdouglas
Copy link
Member

LGTM

@geoand geoand merged commit 28ab92f into quarkusio:master Feb 3, 2021
@geoand geoand deleted the #14607 branch February 3, 2021 06:31
@jonathan-meier jonathan-meier mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/container-image area/core
Projects
None yet
Milestone
1.12.0.CR1
Development

Successfully merging this pull request may close these issues.

Integrate AppCDS generation into Jib container image generation
2 participants
@geoand @stuartwdouglas