-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Passing Client Headers section to rest-client.adoc #14349
Conversation
@pehala thank you for your PR :) It mentions the |
@michalszynkiewicz The main reason why I even have this MR was that I needed to pass Authorization and it was really hard to find some info about how to do it. The thing that was missing the most was the property value which is needed if you don't specify the factory, e.g. you use the default one, which in my opinion will suffice for many cases. If that is ok with you, I can ditch this new section and incorporate only that thing into the existing one. |
👍🏻 |
Could we finalize this PR? Thanks! |
+1 to move that section near (or inside) https://quarkus.io/guides/rest-client#custom-headers-support, for consistency |
Sorry for the delay, I moved the section inside https://quarkus.io/guides/rest-client#custom-headers-support. Is it now ok? |
Could you squash the commits in this PR to a single commit too? |
Squashed and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This section can be useful for passing Authorization headers in rest-client requests. The text is based on javadoc here https://github.com/eclipse/microprofile-rest-client/blob/master/api/src/main/java/org/eclipse/microprofile/rest/client/ext/DefaultClientHeadersFactoryImpl.java.