Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume,sidecar and hostalias support for knative #13939

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Fix volume,sidecar and hostalias support for knative #13939

merged 1 commit into from
Dec 18, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Dec 17, 2020

Resolves: #12121

@ghost
Copy link

ghost commented Dec 17, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@ghost ghost added area/dependencies Pull requests that update a dependency file area/kubernetes labels Dec 17, 2020
@iocanel iocanel changed the title fix (#12121) fix volume,sidecar and hostalias support for knative Fix volume,sidecar and hostalias support for knative Dec 17, 2020
@iocanel iocanel merged commit 26b5f99 into quarkusio:master Dec 18, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Milestone
1.11.0.Beta2
Development

Successfully merging this pull request may close these issues.

Knative deployments do not generate proper volume mounts for secrets volumes
2 participants
@iocanel @geoand