Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using Quarkiverse Hub to publish extension #13922

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Suggest using Quarkiverse Hub to publish extension #13922

merged 2 commits into from
Dec 16, 2020

Conversation

gastaldi
Copy link
Contributor

Also notify Quarkiverse maintainers about new kind/extension-proposal tickets

@ghost ghost added area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Dec 16, 2020
@gastaldi gastaldi requested review from gsmet and FroMage December 16, 2020 13:07
@gastaldi gastaldi force-pushed the quarkiverse branch 2 times, most recently from b2fbaf8 to 641af16 Compare December 16, 2020 15:29
@gastaldi gastaldi requested a review from FroMage December 16, 2020 15:34
@gastaldi gastaldi force-pushed the quarkiverse branch 2 times, most recently from e1f9db1 to a907cf9 Compare December 16, 2020 19:51
gsmet
gsmet requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor suggestions. Other than that, it looks very good!

docs/src/main/asciidoc/building-my-first-extension.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-my-first-extension.adoc Outdated Show resolved Hide resolved
gsmet
gsmet approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I squashed the last commit. Let's get this merged once CI is green.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 16, 2020
@gsmet gsmet merged commit 5ef0548 into quarkusio:master Dec 16, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 16, 2020
@gastaldi gastaldi deleted the quarkiverse branch December 16, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@gastaldi @FroMage @gsmet