Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce test dependencies scope #13919

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Enforce test dependencies scope #13919

merged 1 commit into from
Jan 4, 2021

Conversation

famod
Copy link
Member

@famod famod commented Dec 16, 2020

https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Litle.20error.20on.20quarkus-panache.20poms.201.2E9.2E2-Final

Avoids manual cleanups like #13916.

Example:

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-test-deps-scope) @ quarkus-panache-common ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found test dependencies with wrong scope:
Found Banned Dependency: org.junit.jupiter:junit-jupiter-api:jar:5.7.0
Use 'mvn dependency:tree' to locate the source of the banned dependencies.

Note: independent-projects are not covered because they don't inherit from build-parent. Edit: Should be ok since those projects are used by other modules that do inherit from build-parent, so we can rely on the transitive check.

  • check quarkus-junit-* as discussed via chat

@ghost ghost added area/dependencies Pull requests that update a dependency file area/panache area/security area/testing labels Dec 16, 2020
@famod
Copy link
Member Author

famod commented Dec 16, 2020

Just let me know if we really want to copy the execution to each independent project. See updated PR description.

@ghost ghost added the area/core label Dec 16, 2020
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@geoand geoand requested review from gastaldi and gsmet December 16, 2020 15:27
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit e7c8c3c into quarkusio:master Jan 4, 2021
@ghost ghost added this to the 1.11 - master milestone Jan 4, 2021
@gsmet
Copy link
Member

gsmet commented Jan 4, 2021

Thanks!

@famod famod deleted the enforce-test-deps-scope branch January 4, 2021 17:01
@famod famod mentioned this pull request Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants