Issue with the SecurityIdentity on the IO Thread #13866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
stuartwdouglas
force-pushed
the
13835
branch
from
13ed423 to
2dd6064
Compare
sberyozkin
reviewed
Dec 14, 2020
.../security/runtime/src/main/java/io/quarkus/security/runtime/SecurityIdentityAssociation.java
Show resolved
Hide resolved
stuartwdouglas
force-pushed
the
13835
branch
from
2dd6064 to
f17b0b9
Compare
|
Hi Stuart, one test is failing, |
stuartwdouglas
force-pushed
the
13835
branch
from
f17b0b9 to
3190f23
Compare
This will no longer wrap the Identity in a Uni if proactive auth is in use. This also resolves a problem with setting the current SecurityIdentity via a CDI event, which is not compatible with lazy authentication. Note that the problem can still occur if using lazy auth from the IO thread, which is expected. To get the identity in this situation you need to use CurrentIdentityAssociation#getDeferredIdentity and subscribe to the result. Fixes quarkusio#13835
stuartwdouglas
force-pushed
the
13835
branch
from
3190f23 to
b0246e2
Compare
sberyozkin
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will no longer wrap the Identity in a Uni if
proactive auth is in use.
This also resolves a problem with setting the current
SecurityIdentity via a CDI event, which is not
compatible with lazy authentication.
Note that the problem can still occur if using lazy
auth from the IO thread, which is expected. To get
the identity in this situation you need to use
CurrentIdentityAssociation#getDeferredIdentity
and subscribe to the result.
Fixes #13835