Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTracing Command Listener to MongoDB client #13863

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

juazugas
Copy link
Contributor

Following the instructions in the OpenTracing Mongo Driver Instrumentation there is a way to include the tracing information simply adding a CommandListener to the mongoclient settings.

After the work done on #12082, it is accomplished by adding the MongoTracingCommandListener to the list of CommandListeners to be set to the mongoclient settings.

Project sample https://github.com/juazugas/quarkus-mongodb-opentracing/

Discussion: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/possible.20new.20extension.20for.20mongodb.20client.20and.20opentracing

@ghost
Copy link

ghost commented Dec 13, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@ghost ghost added area/dependencies Pull requests that update a dependency file area/documentation area/mongodb labels Dec 13, 2020
@juazugas juazugas changed the title Add OpenTracing Command Listener to MongoDB client. Add OpenTracing Command Listener to MongoDB client Dec 13, 2020
@juazugas juazugas force-pushed the ext-mongodb-opentracing-listener branch from d4fa8a5 to 03a7217 Compare December 14, 2020 07:22
@gsmet
Copy link
Member

gsmet commented Feb 3, 2021

Any chance this PR could get finalized?

@loicmathieu
Copy link
Contributor

@juazugas if you don't have time to finish the work I can continue where you left ?

@juazugas
Copy link
Contributor Author

juazugas commented Feb 8, 2021

@juazugas if you don't have time to finish the work I can continue where you left ?

I will work on this PR this week starting today. Thanks

@juazugas juazugas force-pushed the ext-mongodb-opentracing-listener branch from 03a7217 to 754517b Compare February 9, 2021 18:33
@juazugas juazugas force-pushed the ext-mongodb-opentracing-listener branch from 754517b to 6bf459c Compare February 10, 2021 18:46
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks

@loicmathieu loicmathieu added this to the 1.13 - master milestone Feb 11, 2021
@loicmathieu
Copy link
Contributor

@gsmet maybe you want to have a look at the documentation addition before merging this one ?

@juazugas
Copy link
Contributor Author

LGTM.
Thanks

Thanks @loicmathieu for your guidance and the review.

Base automatically changed from master to main March 12, 2021 15:55
@gsmet gsmet force-pushed the ext-mongodb-opentracing-listener branch from 6bf459c to 9439c6c Compare March 17, 2021 12:23
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 17, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 17, 2021
@gsmet
Copy link
Member

gsmet commented Mar 17, 2021

This one fell through the cracks unfortunately. I rebased it on latest main. Let's see how CI goes.

@juazugas
Copy link
Contributor Author

@gsmet Do you prefer I do the rebase to main and solve the conflicts (plus interactive rebase and push the branch) ?
The conflicts is because the line before the new version property has changed.

@gsmet gsmet force-pushed the ext-mongodb-opentracing-listener branch from 8ca78b0 to b2c5349 Compare April 1, 2021 12:29
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 1, 2021
@gsmet
Copy link
Member

gsmet commented Apr 1, 2021

I did another rebase, will merge as soon as CI is green (forgot to add the waiting-for-ci label the other time and forgot again about it!).

@gsmet gsmet merged commit fa50d36 into quarkusio:main Apr 2, 2021
@quarkus-bot quarkus-bot bot added this to the 1.14 - main milestone Apr 2, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 2, 2021
@gsmet
Copy link
Member

gsmet commented Apr 2, 2021

Merged, thanks!

@gsmet gsmet modified the milestones: 1.14 - main, 1.13.1.Final Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/mongodb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants