-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTracing Command Listener to MongoDB client #13863
Add OpenTracing Command Listener to MongoDB client #13863
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
d4fa8a5
to
03a7217
Compare
...godb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java
Outdated
Show resolved
Hide resolved
...godb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java
Outdated
Show resolved
Hide resolved
...odb-client/runtime/src/main/java/io/quarkus/mongodb/tracing/MongoTracingCommandListener.java
Show resolved
Hide resolved
Any chance this PR could get finalized? |
@juazugas if you don't have time to finish the work I can continue where you left ? |
I will work on this PR this week starting today. Thanks |
03a7217
to
754517b
Compare
...godb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java
Outdated
Show resolved
Hide resolved
...godb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java
Outdated
Show resolved
Hide resolved
754517b
to
6bf459c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks
@gsmet maybe you want to have a look at the documentation addition before merging this one ? |
Thanks @loicmathieu for your guidance and the review. |
6bf459c
to
9439c6c
Compare
This one fell through the cracks unfortunately. I rebased it on latest main. Let's see how CI goes. |
@gsmet Do you prefer I do the rebase to main and solve the conflicts (plus interactive rebase and push the branch) ? |
8ca78b0
to
b2c5349
Compare
I did another rebase, will merge as soon as CI is green (forgot to add the |
Merged, thanks! |
Following the instructions in the OpenTracing Mongo Driver Instrumentation there is a way to include the tracing information simply adding a CommandListener to the mongoclient settings.
After the work done on #12082, it is accomplished by adding the MongoTracingCommandListener to the list of CommandListeners to be set to the mongoclient settings.
Project sample https://github.com/juazugas/quarkus-mongodb-opentracing/
Discussion: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/possible.20new.20extension.20for.20mongodb.20client.20and.20opentracing