Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that suspended transaction is always resumed #13855

Merged

Conversation

Postremus
Copy link
Member

If an exception happen inside commit (like an SQLException), the afterEndTransaction Runnable would not run.
This caused the suspended Transaction to be never resumed, for e.g. a nested Transaction REQUIRES_NEW.
Related to #13776.

If an exception happen inside commit (like an SQLException), the afterEndTransaction Runnable would not run.
This caused the suspended Transaction to be never resumed, for e.g. a nested Transaction REQUIRES_NEW.
@ghost ghost added the area/narayana Transactions / Narayana label Dec 12, 2020
@gsmet gsmet requested a review from Sanne December 14, 2020 09:17
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@Sanne Sanne added this to the 1.11 - master milestone Dec 14, 2020
@Sanne Sanne merged commit e3c3968 into quarkusio:master Dec 14, 2020
@Postremus Postremus deleted the 13776-fix-wrong-transaction-exception branch December 14, 2020 11:27
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.4.Final Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/narayana Transactions / Narayana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants