Avoid ICC_ColorSpace instances in Apache Tika to support GraalVM 20.3 #13718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gsmet
requested changes
Dec 5, 2020
| @@ -0,0 +1,36 @@ | |||
| package io.quarkus.tika.graalvm; | |||
There was a problem hiding this comment.
That looks great, thanks!
Minor nitpick: this class should be in the io.quarkus.tika.runtime.graal to be consistent with other extensions.
| } | ||
|
|
||
| // Substitutions to prevent ICC_ColorSpace instances from appearing in the native image when using Apache Tika | ||
| // See https://github.com/quarkusio/quarkus/pull/13644 |
There was a problem hiding this comment.
Maybe we should add a comment adding that this class should be removed once we switch from GraalVM 20.3 to GraalVM 21?
(having 20.3 in the comment is important, this way I will catch it when upgrading from 20.3 as I will look for 20.3 occurrences everywhere)
|
I made the adjustments and pushed the commits there: #13644 . Let's see how it goes for CI and make further adjustments in my GraalVM 20.3 branch. |
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache tika integration test.
Note however that users still need to avoid bringing instances of
ICC_ColorSpacein the native image (this is a limitation of GraalVM 20.3 that I am afraid we can't work around in Quarkus. The good thing is that it won't be present in 21.0, since it's already fixed in graalmaster).Another thing to keep in mind is that there are at least two more classes in pdfbox that hold instances of
ICC_ColorSpace:which, although not reachable from the existing test, if reachable through Apache Tika might also cause issues to users.