Allow injection of SearchSession/SearchMapping #13696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area/documentation
area/hibernate-orm
10 tasks
yrodiere
force-pushed
the
search-inject
branch
from
a070752 to
ba58b16
Compare
yrodiere
force-pushed
the
search-inject
branch
from
ba58b16 to
b7dd16e
Compare
gastaldi
reviewed
Dec 4, 2020
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Yes, they need Elasticsearch so they are run if -Dtest-containers
gsmet
reviewed
Dec 4, 2020
| quarkus.hibernate-search-orm.elasticsearch.hosts=${elasticsearch.hosts:localhost:9200} | ||
| quarkus.hibernate-search-orm.elasticsearch.protocol=${elasticsearch.protocol:http} | ||
| quarkus.hibernate-search-orm.schema-management.strategy=drop-and-create-and-drop | ||
| quarkus.hibernate-search-orm.automatic-indexing.synchronization.strategy=sync |
There was a problem hiding this comment.
Don't you expect the configuration to be potentially different depending on the PU?
Doesn't need to be part of this PR, just asking.
There was a problem hiding this comment.
Right now you can make do by defining one backend per PU, but some settings (like this one) will have to be the same on all PUs, which is not great.
So yes, we'd need additional changes to fully support multiple PUs. In another PR :)
…ts API contracts This is important for Hibernate Search in particular.
…y from a TransactionScopedSession This is important for Hibernate Search in particular. Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
…orm-elasticsearch/deployment Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
yrodiere
force-pushed
the
search-inject
branch
from
b7dd16e to
abf99e7
Compare
Sanne
approved these changes
Dec 7, 2020
| This extension is based on a beta version of Hibernate Search. | ||
| While APIs are quite stable and the code is of production quality and thoroughly tested, some features are still missing, performance might not be optimal and some APIs or configuration properties might change as the extension matures. | ||
| ==== | ||
|
|
| ---- | ||
| <1> Inject a Hibernate Search session, which relies on the `EntityManager` under the hood. | ||
| Applications with multiple persistence units can use a CDI qualifier to select the right one: | ||
| either `@Named` or `@io.quarkus.hibernate.orm.PersistenceUnit`. |
There was a problem hiding this comment.
Not a blocker, but I'd prefer such a note to be fully expressed with an example.
There was a problem hiding this comment.
Ok, I'll add an example in the next PR that adds first-class support for multiple PUs.
Sanne
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13694, which should be merged first. Creating this PR as a draft until it's done.Related quickstart update: quarkusio/quarkus-quickstarts#725