Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Panache / Reactive integration tests in native mode #13680

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Fix Panache / Reactive integration tests in native mode #13680

merged 2 commits into from
Dec 3, 2020

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Dec 3, 2020 •
edited by Sanne
Loading

all calls must go via REST
and it was just not needed

Fixes #13672
Fixes #13668

@FroMage
Fix quarkusio#13672 don't do Panache calls in the test for native
69f07d5 
all calls must go via REST
and it was just not needed
@ghost
Copy link

ghost commented Dec 3, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

@FroMage FroMage requested a review from Sanne December 3, 2020 16:43
@ghost ghost added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Dec 3, 2020
@Sanne
Copy link
Member

Sanne commented Dec 3, 2020

Looks good. I'll amend the description

@Sanne Sanne changed the title Fix #13672 don't do Panache calls in the test for native Fix Panache / Reactive integration tests in native mode Dec 3, 2020
Sanne
Sanne approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's wait for the CI logs to see that it actually did run the expected tests.

@gsmet gsmet merged commit 955d150 into quarkusio:master Dec 3, 2020
@ghost ghost added this to the 1.11 - master milestone Dec 3, 2020
@gsmet
Copy link
Member

gsmet commented Dec 3, 2020

I checked the tests have been run.

@Sanne
Copy link
Member

Sanne commented Dec 3, 2020

And they passed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Milestone
1.11.0.Beta1
3 participants
@FroMage @Sanne @gsmet