Upgrade to Hibernate ORM 5.4.25.Final #13607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanne
added
kind/enhancement
ghost
added
area/core
area/dependencies
gsmet
reviewed
Dec 2, 2020
| @@ -195,6 +205,14 @@ public Properties getPuProperties() { | |||
| public void setPuProperties(Properties puProperties) { | |||
| this.puProperties = puProperties; | |||
| } | |||
|
|
|||
| public boolean isEnversIsPresent() { | |||
There was a problem hiding this comment.
Minor nitpicking but this method name looks very weird. The boolean should be called enversPresent and the method isEnversPresent.
…nitDescriptorBuildItem
gsmet
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no particular Quarkus issue fixed by this upgrade, but it's a requirement for the upcoming Hibernate Reactive upgrade.
The changes in the Envers capability are required, as otherwise Envers will NPE at boot - this is a consequence of an optimisation in ORM (which we can improve on in the next upgrade as the NPE clearly is not ideal) but I believe it goes into a good direction: to be able to remove the XML parsers as dependencies in the next round.