Register generated output dir for kotlin gradle plugin #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area/devtools
|
@michalszynkiewicz do you think you could have a look ? |
| @@ -29,6 +29,7 @@ | |||
|
|
|||
| public static final String QUARKUS_GENERATED_SOURCES = "quarkus-generated-sources"; | |||
| public static final String QUARKUS_TEST_GENERATED_SOURCES = "quarkus-test-generated-sources"; | |||
| public static final String[] CODE_GENERATION_PROVIDER = new String[] { "grpc" }; | |||
There was a problem hiding this comment.
could you add a TODO to get this list dynamically (if it's not easy enough to just do it ;) )?
|
@glefloch I added one comment. It would be great if the list could be "not hardcoded". |
|
But it could be done in a separate change. |
michalszynkiewicz
approved these changes
Dec 3, 2020
glefloch
force-pushed
the
fix/12874
branch
2 times, most recently
from
7800c2e to
c0deb5f
Compare
glefloch
force-pushed
the
fix/12874
branch
2 times, most recently
from
20174a2 to
cd89070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like when no
src/main/javais present, the kotlin task does not trigger thecompileJava.This register the
build/classes/java/quarkus-generated-sources/grpcdirectory in the main sourceset (it does the same thing for tests).The only thing that I don't like, is that I cannot load the provider name (e.g. grpc) dynamically has done in the extension.
Also, I re enabled the
KotlinGRPCProjectBuildTest, it pass on my machine and on the Release build Test job on my fork.close #12874