Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenShift doc to account for new environment variable options #13501

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

metacosm
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Nov 26, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/feat/fix/docs but be a proper sentence

This message is automatically generated by a bot.

@ghost ghost added the area/documentation label Nov 26, 2020
@metacosm metacosm changed the title fix: update doc to account for new environment variable options Update doc to account for new environment variable options Nov 26, 2020
@metacosm metacosm changed the title Update doc to account for new environment variable options Update OpenShift doc to account for new environment variable options Nov 26, 2020
@geoand geoand requested a review from iocanel November 26, 2020 19:50
gsmet
gsmet previously requested changes Nov 26, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, you don't like spaces after a dot :).

@@ -23,7 +23,7 @@ To complete this guide, you need:

== Creating the Maven project

First, we need a new project that contains the OpenShift extension. This can be done using the following command:
First, we need a new project that contains the OpenShift extension.This can be done using the following command:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, no :).

[#env-vars-backwards]
===== Backwards compatibility

Previous versions of the OpenShift extension supported a different syntax to add environment variables.The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Previous versions of the OpenShift extension supported a different syntax to add environment variables.The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax.
Previous versions of the OpenShift extension supported a different syntax to add environment variables. The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax.

| |`quarkus.openshift.env-vars.foo.value=field` | `quarkus.openshift.env.mapping.foo.with-key=field` |
|====

NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem.For example, if you define both
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem.For example, if you define both
NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem. For example, if you define both

@metacosm
Copy link
Contributor Author

That is weird…

@geoand
Copy link
Contributor

geoand commented Nov 27, 2020

Some IDE setting maybe?

@metacosm
Copy link
Contributor Author

metacosm commented Nov 27, 2020

Some IDE setting maybe?

More like a bug in the IDEA asciidoc plugin because it's not really consistent… Not sure what's going on there but that is weird. Another weird thing is that it doesn't even show me that one of these lines was modified in the last commit so there's something funky going on…

@metacosm metacosm force-pushed the update-openshift-doc branch from 4c8fff2 to 1d4b85e Compare November 27, 2020 07:56
@geoand
Copy link
Contributor

geoand commented Nov 27, 2020

Another weird thing is that it doesn't even show me that one of these lines was modified in the last commit so there's something funky going on…

Maybe you have configured it to not show whitespace changes?

@metacosm
Copy link
Contributor Author

Another weird thing is that it doesn't even show me that one of these lines was modified in the last commit so there's something funky going on…

Maybe you have configured it to not show whitespace changes?

No, it's not that, it won't even show the line was changed when using Annotate with git blame.

@geoand geoand dismissed gsmet’s stale review November 27, 2020 17:13

Spacing issue addressed

@gsmet gsmet merged commit 819fea1 into quarkusio:master Nov 27, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 27, 2020
@metacosm metacosm deleted the update-openshift-doc branch November 27, 2020 23:14
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.2.Final Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants