-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenShift doc to account for new environment variable options #13501
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, you don't like spaces after a dot :).
@@ -23,7 +23,7 @@ To complete this guide, you need: | |||
|
|||
== Creating the Maven project | |||
|
|||
First, we need a new project that contains the OpenShift extension. This can be done using the following command: | |||
First, we need a new project that contains the OpenShift extension.This can be done using the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, no :).
[#env-vars-backwards] | ||
===== Backwards compatibility | ||
|
||
Previous versions of the OpenShift extension supported a different syntax to add environment variables.The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous versions of the OpenShift extension supported a different syntax to add environment variables.The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax. | |
Previous versions of the OpenShift extension supported a different syntax to add environment variables. The older syntax is still supported but is deprecated and it's advised that you migrate to the new syntax. |
| |`quarkus.openshift.env-vars.foo.value=field` | `quarkus.openshift.env.mapping.foo.with-key=field` | | ||
|==== | ||
|
||
NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem.For example, if you define both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem.For example, if you define both | |
NOTE: If you redefine the same variable using the new syntax while keeping the old syntax, **ONLY** the new version will be kept and a warning will be issued to alert you of the problem. For example, if you define both |
That is weird… |
Some IDE setting maybe? |
More like a bug in the IDEA asciidoc plugin because it's not really consistent… Not sure what's going on there but that is weird. Another weird thing is that it doesn't even show me that one of these lines was modified in the last commit so there's something funky going on… |
4c8fff2
to
1d4b85e
Compare
Maybe you have configured it to not show whitespace changes? |
No, it's not that, it won't even show the line was changed when using |
No description provided.