Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive routes - if needed propagate req. context activated by filter #13458

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Reactive routes - if needed propagate req. context activated by filter #13458

merged 1 commit into from
Nov 25, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 24, 2020

@ghost ghost added the area/vertx label Nov 24, 2020
@mkouba mkouba mentioned this pull request Nov 24, 2020
Closed
@mkouba
Reactive routes - fix request context propagation
2cda14d 
If there is a route filter and the request can have body (POST, PUT, etc.) then
the route method is invoked asynchronously (once all data are read). However,
the request context is activated by the filter and so we need to make sure the
same context is then used in the route method.

- resolves quarkusio#13073
@mkouba mkouba marked this pull request as ready for review November 25, 2020 08:15
@mkouba mkouba requested review from cescoffier and geoand November 25, 2020 08:16
geoand
geoand approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit 04283ec into quarkusio:master Nov 25, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 25, 2020
@gsmet
Copy link
Member

gsmet commented Nov 30, 2020

This will have to wait for 1.11. It conflicts all over the place.

@mkouba
Copy link
Contributor Author

mkouba commented Nov 30, 2020

This will have to wait for 1.11. It conflicts all over the place.

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.

@RequestScope with Filter and reactive routes
4 participants
@mkouba @gsmet @cescoffier @geoand