Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debugHost for Gradle's QuarkusDev #13454

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix debugHost for Gradle's QuarkusDev #13454

merged 1 commit into from
Nov 30, 2020

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 24, 2020

No description provided.

@ghost ghost added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Nov 24, 2020
@gsmet gsmet requested a review from stuartwdouglas November 24, 2020 13:56
@gsmet
Copy link
Member Author

gsmet commented Nov 24, 2020

Apparently, this breaks the Gradle tests entirely.

@gsmet gsmet marked this pull request as draft November 24, 2020 17:05
@geoand
Copy link
Contributor

geoand commented Nov 24, 2020

That is super weird...

@glefloch
Copy link
Member

Yes all dev mode test are failing

@gsmet
Copy link
Member Author

gsmet commented Nov 29, 2020

It was also missing a default value. It should be good now.

@gsmet gsmet marked this pull request as ready for review November 29, 2020 20:23
@gsmet gsmet added triage/backport-1.7? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 29, 2020
@gsmet gsmet merged commit b8f59e9 into quarkusio:master Nov 30, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 30, 2020
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.2.Final Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.10.2.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @geoand @glefloch