-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add characterEscapeHandler TypedXmlWriter xmlseeAlso support and fix separator jaxbindex #13408
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
just move all jaxb stuff added to cxf extension to jaxb one and a fix on jaxb index report by user on cxf extension. |
maybe some stuff are not needed... |
4f5448a
to
0782606
Compare
@gsmet any news? I can split all modification wth different commit. |
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions and questions.
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
@dufoli any chance to address the comments on this PR before we merge this? |
I have totally forget this pr. I will Check review |
d182c44
to
b6d343b
Compare
hmmm. I do not know if cxf support jaxb 3.0 .... |
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2bfde42
Test Failures⚙️ JVM Tests - JDK 11 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/resteasy/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/liquibase/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/rest-client-jaxb/deployment✖ 📦 extensions/resteasy-classic/resteasy-jaxb/deployment✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 core/test-extension/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/liquibase/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/rest-client-jaxb/deployment✖ 📦 extensions/resteasy-classic/resteasy-jaxb/deployment✖ ✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/resteasy-reactive/target/testsuite/tests✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Native Tests - Data3 #📦 integration-tests/hibernate-orm-panache-kotlin✖ ✖ ✖ ✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building f12cef6
Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/liquibase/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/rest-client-jaxb/deployment✖ 📦 extensions/resteasy-classic/resteasy-jaxb/deployment✖ ✖ ⚙️ JVM Tests - JDK 11 Windows #📦 extensions/liquibase/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/rest-client-jaxb/deployment✖ 📦 extensions/resteasy-classic/resteasy-jaxb/deployment✖ ✖ ⚙️ JVM Tests - JDK 16 #📦 extensions/liquibase/deployment✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ 📦 extensions/resteasy-classic/rest-client-jaxb/deployment✖ 📦 extensions/resteasy-classic/resteasy-jaxb/deployment✖ ✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/resteasy-reactive/target/testsuite/tests✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Native Tests - Data3 #📦 integration-tests/hibernate-orm-panache-kotlin✖ ✖ ✖ ✖ |
extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building cf41df5
Full information is available in the Build summary check run. Test Failures⚙️ Native Tests - Data3 #📦 integration-tests/hibernate-orm-panache✖
📦 integration-tests/liquibase✖
⚙️ Native Tests - Main #📦 integration-tests/main✖
⚙️ Native Tests - Spring #📦 integration-tests/spring-web✖
|
hello @gastaldi , I have fix your comment. I just discover one thing. That I need to add JaxbFileRootBuildItem but it is complicated to add it in test ... I do not know how to proceed because there is no other way than buildItem (it was done for camel). Can I add a config element for that too ? in cxf people who complain about it use camel. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a0fe26e
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Data3 #- Failing: integration-tests/hibernate-orm-panache integration-tests/liquibase
📦 integration-tests/hibernate-orm-panache✖
📦 integration-tests/liquibase✖
⚙️ Native Tests - Main #- Failing: integration-tests/main
📦 integration-tests/main✖
⚙️ Native Tests - Misc4 #- Failing: integration-tests/jaxb
📦 integration-tests/jaxb✖
⚙️ Native Tests - Spring #- Failing: integration-tests/spring-web
📦 integration-tests/spring-web✖
|
error in native : java.lang.IllegalArgumentException: methods with same signature namespace(java.lang.String) but incompatible return types: [interface com.sun.xml.bind.v2.schemagen.xmlschema.Wildcard, interface com.sun.xml.bind.v2.schemagen.xmlschema.Import] |
When it is ok, I will squash commit. |
Looks ok to me now. Go ahead and squash it so we can finally merge it 👍🏻 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 19c20f9
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 16 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more 📦 extensions/vertx-http/deployment✖
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 19c20f9
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/vertx-http/deployment
! Skipped: core/test-extension/deployment docs extensions/agroal/deployment and 287 more 📦 extensions/vertx-http/deployment✖
⚙️ JVM Tests - JDK 16 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
@gastaldi I have squash (CI error are not related to it). Can you merge it ? or I rebase in order to trigger new build ? |
- Add missing NativeImageProxyDefinitionBuildItem - Support XmlSeeAlso annotations - Fix separator in jaxb index file
@dufoli I rebased it and reworded the commit. It's ready to go once CI passes |
…fix separator in jaxb index file