Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conventional artifact file naming for the generated platform properties and descriptor files #13120

Merged

Conversation

aloubyansky
Copy link
Member

@aloubyansky aloubyansky commented Nov 4, 2020

It fixes one of the issues causing #13104

@aloubyansky aloubyansky requested a review from rsvoboda November 4, 2020 21:32
@aloubyansky aloubyansky added this to the 1.10 - master milestone Nov 4, 2020
@rsvoboda
Copy link
Member

rsvoboda commented Nov 4, 2020

build fails on [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code (default) on project quarkus-cli: Quarkus code generation phase has failed: Failed to bootstrap the application: Failed to create the application model for io.quarkus:quarkus-cli::jar:999-SNAPSHOT: Failed to resolve artifacts: Could not find artifact org.gradle:gradle-tooling-api:jar:6.5 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

[INFO] Quarkus - Command Line Interface ................... FAILURE [ 0.453 s]

Quarkus master builds fine

@aloubyansky aloubyansky force-pushed the platform-properties-repos branch from 7ea402b to e2d6bb8 Compare November 5, 2020 08:06
@rsvoboda
Copy link
Member

rsvoboda commented Nov 5, 2020

Updated PR works with local reproducer.

Trying now in the lab where I push bits into artifactory and consume them from other jobs

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, this fixes the issues when the reproducer is strictly followed.

The main trouble I have with my CI jobs is still present. Alexey is aware of it and works on follow-up changes.
To replicate CI like issue is to run mvn clean before executing mvn test ...

@aloubyansky aloubyansky merged commit 3e98e88 into quarkusio:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants