Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the project object as the source of dependencies instead of 'connecting' to the project #12999

Merged

Conversation

aloubyansky
Copy link
Member

This makes listExtensions, addExtension and removeExtension ~10 times faster.

@maxandersen
Copy link
Member

two questions:

  1. why removal of tests ?
  2. does this knowingly change anything with respect to depednency chains maybe differ or was the connecting part just completely irrelevant to ever do ?

@aloubyansky
Copy link
Member Author

  1. Unless there is another kind of CLI (or some other kind of tool) that needs to connect to the project to list, add and remove extensions then the original implementations of those "connector" "BuildFile"s could be kept and the related tests testing those classes directly.
    Otherwise, all of them can be removed.

  2. I don't see any reason to connect to the project from the "outside" when we are already "inside" the initialized project.

@aloubyansky aloubyansky force-pushed the gradle-project-list-extensions branch from c050fd7 to 51d1b46 Compare October 28, 2020 11:45
@aloubyansky aloubyansky requested a review from ia3andy October 28, 2020 11:45
@aloubyansky aloubyansky added this to the 1.10 - master milestone Oct 28, 2020
@aloubyansky aloubyansky added area/gradle Gradle area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Oct 28, 2020
@aloubyansky aloubyansky requested a review from glefloch October 28, 2020 11:51
@aloubyansky aloubyansky force-pushed the gradle-project-list-extensions branch from 51d1b46 to 31b1f35 Compare October 28, 2020 11:56
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @aloubyansky this will make the CLI (which call the gradle plugin) way faster!

@maxandersen
Copy link
Member

looks good yeah, and based on @aloubyansky explanation that we already are "inside" the project and my limited understanding of the code I'm +1 on this.

@aloubyansky aloubyansky merged commit 133cae1 into quarkusio:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants