Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SmallRye Config 1.9.3 #12983

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

@gastaldi
Copy link
Contributor

It also fixes #2292

@gastaldi
Copy link
Contributor

gastaldi commented Oct 27, 2020

Funny that I can't reference that issue in the Linked issues list

UPDATE: it works if I do it from the issue

@gastaldi gastaldi linked an issue Oct 27, 2020 that may be closed by this pull request
@radcortez
Copy link
Member Author

It also fixes #2292

Ah yes, let me add it as well.

@gsmet
Copy link
Member

gsmet commented Oct 27, 2020

@gastaldi it needs to be in the description of the PR.

@gsmet gsmet changed the title Support SmallRye Config 1.9.3. Upgrade to SmallRye Config 1.9.3 Oct 27, 2020
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
@gastaldi
Copy link
Contributor

@gastaldi it needs to be in the description of the PR.

I know, but it also (sometimes) works if you add to the Linked Issues list

@gsmet gsmet merged commit 3554136 into quarkusio:master Oct 27, 2020
@rsvoboda
Copy link
Member

Regarding issue #2292, this error gets printed

$ java -Dquarkus.log.console.darken=1.5 -jar target/quarkus-app-1.0-SNAPSHOT-runner.jar
Oct 28, 2020 6:13:10 PM io.quarkus.config
ERROR: An invalid value was given for configuration key "quarkus.log.console.darken": SRCFG00029: Expected an integer value, got "1.5"
Oct 28, 2020 6:13:10 PM io.quarkus.runtime.ApplicationLifecycleManager run
ERROR: Failed to start application (with profile prod)
io.quarkus.runtime.configuration.ConfigurationException: One or more configuration errors has prevented the application from starting. The errors are:
An invalid value was given for configuration key "quarkus.log.console.darken": SRCFG00029: Expected an integer value, got "1.5"

JDK logging is used, can be "standard" one line logging used? Or these errors appear too early in the init phase?

@gsmet gsmet modified the milestones: 1.10 - master, 1.9.1.Final Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants