Introduced io.quarkus.restclient.NoopHostnameVerifier #12970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
requested review from
geoand and
gsmet
and removed request for
geoand
geoand
reviewed
Oct 27, 2020
...st-client/src/main/java/io/quarkus/it/rest/client/selfsigned/ExternalSelfSignedResource.java
Show resolved
Hide resolved
gastaldi
force-pushed
the
hostname_verifier
branch
2 times, most recently
from
a0edfde to
7b2e2ab
Compare
geoand
reviewed
Oct 27, 2020
...st-client/src/main/java/io/quarkus/it/rest/client/selfsigned/ExternalSelfSignedResource.java
Outdated
Show resolved
Hide resolved
gsmet
previously requested changes
Oct 27, 2020
...ns/rest-client/runtime/src/main/java/io/quarkus/restclient/runtime/NoopHostnameVerifier.java
Outdated
Show resolved
Hide resolved
gastaldi
force-pushed
the
hostname_verifier
branch
from
7b2e2ab to
e1cf4ce
Compare
gastaldi
changed the title
This should be used in the rest-client when hostname verification needs to be disabled for a specific client endpoint Also tests were improved to use what's provided in the rest-client extension
gastaldi
force-pushed
the
hostname_verifier
branch
from
e1cf4ce to
5e4eb66
Compare
|
The java.net.URL test is back again, thanks @geoand for the explanation on why it is important |
|
Since this PR introduces a new class and 1.10 is almost here, I'll remove the backport label |
geoand
approved these changes
Nov 1, 2020
|
Thanks 👍 |
gastaldi
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be used in the rest-client when hostname verification needs to be disabled for a specific client endpoint.
Also tests were improved to use what's provided in the rest-client extension